samples/applications: remove option CONFIG_USB_UART_CONSOLE #6217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfischer-no
requested review from
MarekPorwisz,
anangl,
carlescufi and
eobalski
jfischer-no
requested review from
Damian-Nordic,
KAGA164,
alwa-nordic,
kkasperczyk-no,
lmaciejonczyk,
pdunaj,
rlubos,
tejlmand and
trond-snekvik
as code owners
github-actions
bot
added
changelog-entry-required
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
jfischer-no
removed
CI-all-test
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
lmaciejonczyk
approved these changes
Nov 26, 2021
MarekPorwisz
approved these changes
Nov 26, 2021
Damian-Nordic
approved these changes
Nov 26, 2021
trond-snekvik
approved these changes
Nov 26, 2021
eobalski
approved these changes
Nov 26, 2021
jfischer-no
force-pushed
the
pr-fix-shell-console-dependency
branch
from
aac121f to
8d5646c
Compare
github-actions
bot
added
changelog-entry-required
jfischer-no
removed
CI-all-test
Update sdk-zephyr revision to include the patches that resolve configuration dependency between console and shell and remove unnecessary option CONFIG_USB_UART_CONSOLE. Remove CONFIG_USB_UART_CONSOLE usage in the samples and applications or enable CONFIG_SHELL_BACKEND_SERIAL_CHECK_DTR. samples: openthread: check the compatibility of chosen property instead of usage of CONFIG_USB_UART_CONSOLE option. Signed-off-by: Johann Fischer <[email protected]>
jfischer-no
force-pushed
the
pr-fix-shell-console-dependency
branch
from
8d5646c to
a5031dd
Compare
github-actions
bot
added
changelog-entry-required
pdunaj
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sdk-zephyr revision to include the patches that resolve
configuration dependency between console and shell and remove
unnecessary option CONFIG_USB_UART_CONSOLE.
Remove CONFIG_USB_UART_CONSOLE usage in the samples and applications
or enable CONFIG_SHELL_BACKEND_SERIAL_CHECK_DTR.
samples: openthread: check the compatibility of chosen property
instead of usage of CONFIG_USB_UART_CONSOLE option.